Skip to content

Stringify More Conditions #6031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xxAtrain223 wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Stringify More Conditions #6031

xxAtrain223 wants to merge 8 commits into from

Conversation

@xxAtrain223
Copy link
Contributor

@xxAtrain223 xxAtrain223 commented Dec 19, 2025 •
edited by github-actions bot
Loading

Stringified more logic conditions so they can be used in the Logic Tracker.

Build Artifacts

serprex
serprex approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@serprex serprex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with more logic moving into EventAccess & Entrances this'll be useful. Logic viewer really needs to render chain of regions in area to reach check. As for rendering EventAccess I'm not sure

(eg #6027 where windmill PoH location now appears twice, only requiring boomerang or nothing)

@xxAtrain223
Copy link
Contributor Author

xxAtrain223 commented Dec 21, 2025

I think the Logic Tracker already has that covered. e.g. The Kakariko cow, it's in two locations in two regions, and access can be viewed from the entrance chains.
image

@xxAtrain223
Copy link
Contributor Author

xxAtrain223 commented Jan 2, 2026

Ping me if you want to merge this, and I'll fix the conflicts.
Here's the regex I use to convert 95% of the constructors to macros.

Entrance\(\s*([A-Za-z0-9_]+)(\s*,\s*)\[\]\{return (.*?);\}\s*(,.*?)?\),
ENTRANCE($1$2$3$4),

EventAccess\(\s*([^\s,]+)(\s*,\s*)\[\]\s*\{\s*return (.*?);\s*\}\s*\),
EVENT_ACCESS($1$2$3),

Pepe20129
Pepe20129 approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@Pepe20129 Pepe20129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanCheckConditionString should probably be renamed but that's not a blocker

@serprex
Copy link
Contributor

serprex commented Jan 12, 2026

Will get to this in after a couple more shuffles get in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serprex serprex serprex approved these changes

+1 more reviewer

@Pepe20129 Pepe20129 Pepe20129 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xxAtrain223 @serprex @Pepe20129